-
-
Notifications
You must be signed in to change notification settings - Fork 433
Can enable debug logging of the gRPC calls. #1065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
if (debug) { | ||
args.push('--debug'); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be useful to let the user set the debug file too, like this:
if (debug) { | |
args.push('--debug'); | |
} | |
if (debug) { | |
args.push('--debug'); | |
if (debugFilePath) { | |
args.push('--debug-file'); | |
args.push(debugFilePath); | |
} | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but in that case, we should take care about deleting the file after every start-up, otherwise the file size will grow indefinitely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
I edited the commit message and the PR; my changes won't close #1056. I will let you wrap it up when you have figured out how to do the file-based logging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kittaakos ok I asked @cmaglie to make a change in the arduino-cli in order to recreate the log file every time the IDE is restarted. In the meantime, I'm going to add the flag because it already works anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is working perfectly for me and having access to this information has already proven to be very helpful for investigating behavior of the Arduino IDE and Arduino CLI.
Thanks Akos!
Signed-off-by: Akos Kitta <[email protected]>
Motivation
Can enable the debug logging of the gRPC call to the Arduino CLI.
Change description
How to test:
~/.arduinoIDE/settings.json
, you can use IDE2 or your favorite text editor,"arduino.cli.daemon.debug": true
to thesettings.json
file and save it,Other information
Reviewer checklist